Repository navigation
[SCAL-327613] Add Spotter routes to fullHeight height-reset allowlist - #652
Closed
shikharbsar wants to merge 1 commit into
Closed
shikharbsar wants to merge 1 commit into
shikharbsar wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds Spotter (conv-assist) routes to the liveboardRelatedRoutes array in both AppEmbed and LiveboardEmbed to prevent resetting the iframe height during navigation, along with corresponding unit tests. The review feedback highlights a potential partial prefix matching bug due to the lack of trailing slashes on the new routes, and suggests extracting the duplicated route array and matching logic into a shared constants file.
commit: |
bahetirisabh
approved these changes
Sep 10, 2026
Spotter (conv-assist) routes were missing from the RouteChange allowlist that skips the fullHeight iframe height reset, causing the embed to collapse to defaultHeight when navigating into or within Spotter. - Add /insights/conv-assist and /embed/insights/conv-assist to liveboardRelatedRoutes in app.ts and liveboard.ts - Add pinning tests for the bare landing route and the conversation-id URL variant
shikharbsar
force-pushed
the
SCAL-327613
branch
from
September 10, 2026 19:26
8179ecc to
de702ed
Compare
bahetirisabh
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotter (conv-assist) routes were missing from the RouteChange allowlist that skips the fullHeight iframe height reset, causing the embed to collapse to defaultHeight when navigating into or within Spotter.